Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error when translations are not compiled #273

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Catches and remits the error when translation files have not been compiled. The new error tells the user what to do. In theory, this happens only once when someone pulls the *.po files for the first time. This does not detect if the compiled translations are outdate. It also only happens if xscen was installed with pip install -e ..
  • Add a note in the Good To Know page about updating the compiled translations when using xscen from source.
  • Add a line in History about the translation PR.

Does this PR introduce a breaking change?

No

@aulemahal aulemahal requested a review from RondeauG October 16, 2023 19:42
@github-actions github-actions bot added the docs label Oct 16, 2023
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @vindelico

@aulemahal aulemahal merged commit a56041e into main Oct 26, 2023
6 checks passed
@aulemahal aulemahal deleted the better-notrans-error branch October 26, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants